Increase default project quota in the sandbox and demo #3061
Conversation
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
| @@ -102,3 +117,64 @@ redis: | |||
| # --- enable or disable Redis Statefulset installation | |||
| enabled: false | |||
|
|
|||
| # -- Configuration for the Cluster resource manager component. This is an optional component, that enables automatic | |||
| # cluster configuration. This is useful to set default quotas, manage namespaces etc that map to a project/domain | |||
| cluster_resource_manager: | |||
There was a problem hiding this comment.
Why do we need this block?
There was a problem hiding this comment.
IIUC, If we don't add it, the sandbox will use the default config in value.yaml
How did you test this, Kevin?
I rebuilt the sandbox image and ran the command flytectl sandbox start --image pingsutw/sandbox-test to create cluster. Then check if the resource is updated in the configmap.
|
I'm happy about this - I've run into OOM issue during local development as well. Only concern is maybe we're bumping these too high? Ex. we probably don't need a quota for 40 CPU and 30G memory for local development. Maybe something like:
|
Signed-off-by: Kevin Su <[email protected]>
| limits: | ||
| cpu: 2 | ||
| memory: 4Gi | ||
| storage: 20Mi |
There was a problem hiding this comment.
why is this so low? Do we have to set it?
There was a problem hiding this comment.
That is the default value in value.yaml. Yup, it's optional. I just removed it to make the config simple.
Signed-off-by: Kevin Su <[email protected]>
|
Hi, I had some issues with the default demo environment you get when running I was able to prevent things from getting OOMKilled by updating the sandbox configmap according to above values. Would it make sense for you to use these as defaults for the demo environment as well? Let me know if I should open a separate issue for this. |
Signed-off-by: Kevin Su [email protected]
Tracking issue
https://flyte-org.slack.com/archives/C049Q7GDWN9/p1667885776403149
Describe your changes
People often fail to run the workflow in the sandbox or demo cluster because resource exceeds the task default resources or the project quota. Therefore, we increase the quota and default resource to address this issue.
Check all the applicable boxes
Screenshots
Note to reviewers